feat: set remote.SSH.reconnectionGraceTime and refactor settings manipulation#826
Open
feat: set remote.SSH.reconnectionGraceTime and refactor settings manipulation#826
Conversation
EhabY
changed the title
EhabY
force-pushed
the
set-reconnection-grace-time
branch
from
17b3494 to
ad63eff
Compare
EhabY
force-pushed
the
set-reconnection-grace-time
branch
3 times, most recently
from
2ae196e to
fc89a92
Compare
VS Code's default reconnection grace time of 3 hours is too short for Coder workspaces that go offline overnight. Set 8 hours (28800s) when the user hasn't configured a value. Extract the inline jsonc settings manipulation from remote.ts into a reusable applySettingOverrides() function with dedicated tests.
…or Cursor/reconnection Add a command palette entry (Coder: Apply Recommended SSH Settings) that writes all four recommended SSH settings globally. Also automatically set serverShutdownTimeout (Cursor) and maxReconnectionAttempts when undefined during connection setup, matching the existing reconnectionGraceTime behavior.
EhabY
force-pushed
the
set-reconnection-grace-time
branch
from
f756007 to
ead3b59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remote.tsinto a reusableuserSettings.tsmodule withbuildSshOverrides()andapplySettingOverrides()functionsreconnectionGraceTime(8h),serverShutdownTimeout(8h), andmaxReconnectionAttempts(unlimited) when the user hasn't configured them, preventing disconnects during overnight workspace sleepCloses #823